Remove redundant dev install instructions, loosen pydantic pin #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Integration tests report: appsharing.space |
mfisher87
approved these changes
Jan 9, 2025
| @@ -13,8 +13,6 @@ The `jlpm` command is JupyterLab's pinned version of | |||
| git clone https://github.com/geojupyter/jupytergis.git | |||
| # Change directory to the jupytergis directory | |||
| cd jupytergis | |||
| # Install JupyterLab for jlpm | |||
| pip install jupyterlab | |||
mfisher87
changed the title
|
Integration tests are detecting visual regressions, clearly not caused by this PR. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CONTRIBUTING.md guide instructs to install JupyterLab, but it's already present in requirements-build.txt.
Also, pydantic v2.4.2 doesn't seem to have wheels for Python 3.13, and would need a Rust compiler, so I guess a newer version should be allowed.
Checklist
Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--295.org.readthedocs.build/en/295/
💡 JupyterLite preview is available from the doc, by clicking on